Fix compatibility to Portal Reloaded #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Portal Reloaded, a third (time) portal can be placed.
This patch adds another action ("ThirdAttack") for that, by default mapped to left trigger.
In order for this to work, it is also required to fix processing of digital inputs in general:
The previous code (see
PressedDigitalAction()) correctly sent "button pressed" events to the game when a button changed state from released to pressed, but re-sent "button released" events repeatedly at all time when the button was in released state.This is supposed to be a bug and somehow prevented the freshly added ThirdAttack action from being correctly processed by the game engine.
This PR also fixes this and thus closes issue #109.
Note that a short test showed that compatibility to Portal 2 (or Portal Stories: Mel) is unchanged by this PR.