Use isoFormat() instead of format() for placeholder dates #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the issue that Cardon format() does not format the date for weeks "Y-W" correctly with dates that belong to the last week of the previous year. E.g. "2022-01-02" is actually "2021-52", however usual format method would incorrectly output "2022-52"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes an issue with incorrect year numbers on placeholder dates formatted in weeks belonging to the previous year.
Why
By default, using format("Y-W") will return the year of the current date, even if the week is technically part of the previous year. To fix this and to account for the ISO-8601 year, which can differ from the calendar year. Carbon provides the isoFormat method, which respects the ISO-8601 standard for both the year and the week.
E.g. "2022-01-02" is actually "2021-52", however the currently used method would incorrectly output "2022-52".
How
Using isoFormat() instead of format() methods of Carbon Date object together with the ISO date formatting string "GGGG-WW" solves this issue