DRAFT - DO NOT MERGE - V2 Discussions #1716
Conversation
velveetachef
changed the title
velveetachef
force-pushed
the
v2-discussions-release
branch
from
131752a to
97ce863
Compare
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
velveetachef
added
Draft
| @@ -520,7 +510,7 @@ export interface ICreateChannelPost extends IPostOptions, ICreateChannel {} | |||
| * @extends {IHubRequestOptions} | |||
| */ | |||
| export interface ICreatePostParams extends IDiscussionsRequestOptions { | |||
| data: ICreatePost | ICreateChannelPost; | |||
| data: ICreatePost; | |||
There was a problem hiding this comment.
This will require changes to the post-editor component as V2 does not support creating channels on the fly while creating a post; a channelId is now required to be sent through. Need designs from Sam.
| * @hidden | ||
| */ | ||
| channelAclDefinition?: IChannelAclPermissionDefinition[]; | ||
| channelAclDefinition: IChannelAclPermissionDefinition[]; |
There was a problem hiding this comment.
This will have impact on the Discussion Board workspace UI where we create channels. We'll now need to build ACL rules there vs selecting groups/access/allowAnonymous
| access?: SharingAccess; | ||
| allowAnonymous?: boolean; | ||
| groups?: string[]; | ||
| channelAclDefinition?: IChannelAclPermissionDefinition[]; |
There was a problem hiding this comment.
Similar point as above, impacts Discussion Board participation pane where we create/edit channels. Need ACL UI versus legacy access/groups/allowAnonymous
| IUpdateChannelPermissions, | ||
| Partial<IWithAuthor> {} | ||
| extends IUpdateChannelSettings, | ||
| IUpdateChannelPermissions {} |
There was a problem hiding this comment.
This relates to the legacy V1 code creating channels on the fly in private content discussions. The desire was that the channel owner should be the same as the group owner, so the client would override/update the channel owner to mirror that of the group that was configured for the channel. We'll need to kill off that owner reassignment code when we strip out the ability to create channels on the fly.
| blockWords?: string[]; | ||
| defaultPostStatus?: PostStatus; | ||
| metadata?: IChannelMetadata; | ||
| name?: string; |
There was a problem hiding this comment.
New interface to account for delta between the name being required when creating a channel, but optional (can be undefined) when updating due to nature of HTTP patch.
| @@ -57,7 +57,6 @@ export class ChannelPermission { | |||
| private isChannelAclEmpty: boolean; | |||
| private existingChannel: IChannel; | |||
| private permissionsByCategory: PermissionsByAclCategoryMap; | |||
There was a problem hiding this comment.
Merely related to no longer considering channel creator as the channel "owner".
velveetachef
force-pushed
the
v2-discussions-release
branch
from
e1f3768 to
2095df3
Compare
| @@ -71,7 +71,7 @@ export function apiRequest<T>( | |||
| // TODO: we _want_ to use getHubApiUrl(), | |||
| // but have to deal w/ the fact that this package overwrites IHubRequestOptions | |||
| host: options.hubApiUrl || "https://hub.arcgis.com", | |||
| path: "/api/discussions/v1", | |||
| path: "/api/discussions/v2", | |||
There was a problem hiding this comment.
can/should this pull from hubApiEndpoints?
affects: @esri/hub-common
velveetachef
force-pushed
the
v2-discussions-release
branch
from
5be937d to
38ff477
Compare
Issues:
channelIdon post create (no channel create on the fly)Description: Release of breaking changes related to Discussions V2
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.