-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor crash resolved #473
base: master
Are you sure you want to change the base?
Minor crash resolved #473
Conversation
invalid check mistake resolved
Thanks for the PR. Is there an associated test with this? Did it run before? Does it run now? |
Thanks for quick reply. I tested this manually. The loop has to be executed from |
Generated by 🚫 Danger |
Could you edit the test cases here so it gives an asset while running the code:
But doesn't give an assert with:
https://github.com/goktugyil/EZSwiftExtensions/blob/master/EZSwiftExtensionsTests/StringTests.swift |
@@ -438,7 +438,7 @@ extension String { | |||
|
|||
/// EZSE: Checks if String contains Emoji | |||
public func includesEmoji() -> Bool { | |||
for i in 0...length { | |||
for i in 0..<length { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a unit test for this pls ?
invalid check mistake resolved
Checklist