remove module and rootDir from the compilerOptions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nirjan-dev
commented
Oct 30, 2020
nirjan-dev
commented
- Fixes typescript issue while using another svelte component from npm
- Fixes an issue with prop exports in svelte files that use typescript
- related issue
|
@NK-WebDev I know @thisislawatts is working on a typescript change as well. Will these conflict? Elderjs/elderjs#72 |
|
@nickreese He hasn't changed this file in his commits so far but I don't know if he plans to change it latter or if these config values will need to be changed after merging his changes, so for now I can include a link to this PR on the PR for the docs (for ts info). Then We can change the docs later if the typescript setup process changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.