Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix React Native course title #11571

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Taussy10
Copy link

What does this PR do?

It correct the course name in React Native course section

For resources

Description

from React to React Native

Why is this valuable (or not)?

Yeah , it's valuable someone can think what is React course doing in React Native

How do we know it's really free?

It is on publicly upload on Youtube

For book lists, is it a book? For course lists, is it a course? etc.

It's for course list and for React Native course

Checklist:

  • [yes ] Read our contributing guidelines.
  • [ yes] Search for duplicates.
  • [ yes] Include author(s) and platform where appropriate.
  • [ yes] Put lists in alphabetical order, correct spacing.
  • [ yes] Add needed indications (PDF, access notes, under construction).
  • [ yyes] Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link
Member

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is ReactJS Tutorial for Beginners so replace the title with this title.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 15, 2024
@Taussy10
Copy link
Author

The title is ReactJS Tutorial for Beginners so replace the title with this title.

Wait a minute even that link need to change because that is React Native section so there should be React Native course not ReactJS course

Copy link
Member

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer playlist link so just find the playlist link and commit!

@Ajay-singh1
Copy link
Member

@Taussy10 Don't open multiple PR as it waste maintainer time close this PR as I think you have a fix for this in #11584.

@@ -1150,7 +1150,7 @@
* [Introduction to React Native](https://fullstackopen.com/en/part10/introduction_to_react_native) - Full Stack Open
* [React Native for Beginners](https://www.youtube.com/playlist?list=PL4cUxeGkcC9ixPU-QkScoRBVxtPPzVjrQ) - The Net Ninja
* [React Native Tutorial (2021)](https://www.youtube.com/playlist?list=PL8kfZyp--gEXs4YsSLtB3KqDtdOFHMjWZ) - Programming with Mash, MAhdi SHarifimehr
* [React Tutorial for Beginners](https://www.youtube.com/playlist?list=PLC3y8-rFHvwgg3vaYJgHGnModB54rxOk3) - codevolution
* [React Native Tutorial for Beginners](https://www.youtube.com/watch?v=hzzCveeczSQ&list=PLC3y8-rFHvwhiQJD1di4eRVN30WWCXkg1) - codevolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [React Native Tutorial for Beginners](https://www.youtube.com/watch?v=hzzCveeczSQ&list=PLC3y8-rFHvwhiQJD1di4eRVN30WWCXkg1) - codevolution
* [React Native Tutorial for Beginners](https://www.youtube.com/playlist?list=PLC3y8-rFHvwhiQJD1di4eRVN30WWCXkg1) - codevolution

@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Oct 28, 2024
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot removed the conflicts Conflict(s) need to be resolved label Oct 28, 2024
Copy link

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

@github-actions github-actions bot added the conflicts Conflict(s) need to be resolved label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Conflict(s) need to be resolved waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants