Fix dynamic lights intensity, cleanup

[VReaperV]

Cgame-side pr: Unvanquished/Unvanquished#3184
Dynamic light config update for weapon flash colours: UnvanquishedAssets/res-weapons_src.dpkdir#32

• NUKED the weird 4x dynamic light scaling
• NUKED the weird r_lightScale cvar, which is used for dynamic lights, but it's a cheat cvar and always set to 2.0, and essentially only used for dynamic lights spawned from movers
• NUKED RE_AddDynamicLightToSceneQ3A() and renamed RE_AddDynamicLightToSceneET() to RE_AddDynamicLightToScene() because they're essentially the same
• NUKED now unused trap_R_AddAdditiveLightToScene()
• NUKED light intensity/scale, which was only used to scale the light's colour, just multiply the colour earlier on instead
• Fixed some incorrect memory read before bounds check

Fixes #61:
hq-beta28:
Before:

After:

tremtest:
Before:

After:

[slipher]

Why don't we nuke the intensity argument? It seems to be redundant with just changing the r/g/b values.

[VReaperV]

Why don't we nuke the intensity argument? It seems to be redundant with just changing the r/g/b values.

Right, done now.

[slipher]

The forward lighting shader checks the sign of u_LightScale to check for inverse lights. These are said to be already broken, but it would be nice to set the scale to 1 or -1 to at least gesture at how it was supposed to work

[VReaperV]

scale is already removed there, so there's nothing to set.

[slipher]

I tested this branch vs. master and found the dynamic lights are not as bright. I guess if you deleted a factor of 8 of random scaling, you need to add that back in somewhere to get the same result?

Master:

This branch:

[VReaperV]

I tested this branch vs. master and found the dynamic lights are not as bright. I guess if you deleted a factor of 8 of random scaling, you need to add that back in somewhere to get the same result?

Master:

This branch:

I have created a PR in res-weapons repo for this: UnvanquishedAssets/res-weapons_src.dpkdir#32.