Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when multiple Android Service are active #2418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix crash when multiple Android Service are active #2418

wants to merge 1 commit into from

Conversation

mr5z
Copy link

@mr5z mr5z commented Dec 28, 2024 •
edited
Loading

Description of Change

  • Code refactors
    • Change of naming convention of constants
    • Removal of confusing code
    • Update Android Service name
  • Fix crash that occurs in Android Service

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@mr5z mr5z marked this pull request as ready for review December 28, 2024 05:20
ne0rrmatrix
ne0rrmatrix reviewed Dec 28, 2024
View reviewed changes
src/CommunityToolkit.Maui.MediaElement/Services/MediaControlsService.android.cs
@@ -18,15 +18,20 @@
namespace CommunityToolkit.Maui.Media.Services;

[SupportedOSPlatform("Android26.0")]
[Service(Exported = false, Enabled = true, Name = "communityToolkit.maui.media.services", ForegroundServiceType = ForegroundService.TypeMediaPlayback)]
[Service(Exported = false, Enabled = true, Name = "CommunityToolkit.Maui.Media.Services", ForegroundServiceType = ForegroundService.TypeMediaPlayback)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the case to uppercase will break older API's compatibility and prevent app from running on Android 23 or below. We only support android 26+ now on media element but I do want to point out this would break some current apps. Also changing this here requires changing the string in the manifest to match which has not been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ne0rrmatrix ne0rrmatrix ne0rrmatrix left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Using MediaElement in Android causes crash
2 participants
@mr5z @ne0rrmatrix