New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uv shell never exits #558

Merged

robinjhuang merged 1 commit into main from fix-uv-exit

Dec 28, 2024

Contributor

webfiltered commented Dec 24, 2024 •

edited by sync-by-unito bot

Loading

Current:

uv shell continues running until app is closed
kill() is never called - optional chained after an explicitly undefined value
If fixed to use pty.kill(), the EPIPE exception is still raised even with a 10sec timer

Proposed:

Just kill the process ID

┆Issue is synchronized with this Notion page by Unito


          Fix uv shell never exits

e5b3b1b

webfiltered requested a review from a team as a code owner

December 24, 2024 21:03

robinjhuang merged commit 8426150 into main

7 checks passed

robinjhuang deleted the fix-uv-exit branch

December 28, 2024 01:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet