Improve install path selection UX #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix resume install completes but will not start Report installation status on error nit Rename for clarity - InstallationManager Refactor installationvalidator Remove redundant code Remove unused code Add framework for installation validation Set run-once install listener to self-remove [Refactor] Improve promise handling and readability Remove unused code Add logging events Flatten app install call chaining - Adds framework for app state validation - Simplifies call chains (even with additions) Add modal native dialog helpers Add temporary base path updater - updates YAML Add containsDirectory FS helper function Move classes to individual files nit
Returns control of error messages / display formatting to frontend Allows multiple errors / issues to be reported simultaneously
|
NB / commit history: originally planned to allow this commit to be done async, ahead of the frontend commit. It's tightly coupled. Really not worth the time investment - or the requirement for a third PR just to clean up aftwards. Moving on. |
This reverts commit 0d73510.
huchenlei
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents/ComfyUIDocuments/ComfyUI/ComfyUIDocuments/ComfyUIDefault install screen - full install path is now shown in frontend:
┆Issue is synchronized with this Notion page by Unito