Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on load when not using cjs output #497

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix crash on load when not using cjs output #497

merged 2 commits into from
Dec 17, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Dec 16, 2024

┆Issue is synchronized with this Notion page by Unito

toDesktop auto update calls use CommonJS require().
@webfiltered webfiltered requested a review from a team as a code owner December 16, 2024 23:45
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webfiltered Can you investigate why playwright test failed?

@webfiltered
Copy link
Contributor Author

webfiltered commented Dec 17, 2024

Let me know if there are any tips for making it work at all when it's not in CI env. Otherwise, I'll go fix that first.

Edit: It's easier to just pretend you are in CI. Tests can be fixed separately.

CI=1

const args = process.env.CI ? ['--remote-debugging-port=9000', '--remote-allow-origins=http://127.0.0.1:9000' ] : ['--inspect=9223']

@webfiltered webfiltered requested a review from a team as a code owner December 17, 2024 00:37
@webfiltered webfiltered marked this pull request as draft December 17, 2024 01:17
@webfiltered webfiltered marked this pull request as ready for review December 17, 2024 09:45
@huchenlei huchenlei merged commit 5cb8b14 into main Dec 17, 2024
7 checks passed
@huchenlei huchenlei deleted the cjs-fix branch December 17, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants