Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland #362 - improved startup error handling #446

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Reland #362 - improved startup error handling #446

merged 5 commits into from
Dec 6, 2024

Conversation

webfiltered
Copy link
Contributor

Allow user to see result of YAML config read

  • Nature of the failure is returned
  • Invalid values read are included if available
  • Retains inferred types

When the file exists but base_path is just invalid:

  • In this PR, it pretends the file doesn't exist and reinstalls
  • Should be connected to the UI path picker, once finalised

@webfiltered
Reapply "Settings store (#362)" (#440)
d31de10 
This reverts commit 81320e2.
@webfiltered
Allow user to see result of YAML config read
12ae4be 
- Nature of the failure is returned
- Invalid values read are included if available
- Retains inferred types
@webfiltered
Fix cannot start app if invalid install state
e257909 
Current requirement is that a missing YAML file triggers the install screen.
@webfiltered
Detect YAML parse exceptions
86088b2
@webfiltered
Update test expectations
810f504
@huchenlei huchenlei merged commit f5e108d into main Dec 6, 2024
6 checks passed
@huchenlei huchenlei deleted the settings-store-iii branch December 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei