Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit access to core settings #420

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Limit access to core settings #420

merged 4 commits into from
Dec 6, 2024

Conversation

webfiltered
Copy link
Contributor

  • Removes set method from the ComfyUI core settings reader
    • Unused, and there is no write method so it seems misleading
  • Adds guards for permission / filesystem errors
  • Converts to async FS access

@webfiltered
Remove unused code: settings set()
b7f31e6 
Adds doc explaining why it is not available: file managed by core.
@webfiltered
nit
dad40b9
@webfiltered
Add guards & async to core settings reader
55a3bea 
Handles:
- Access denied / other FS errors
- Storage non-responsive
@webfiltered
nit
664d8d8
@huchenlei
Copy link
Member

Note: blocked on reland of #362

@robinjhuang robinjhuang merged commit 2d51c73 into main Dec 6, 2024
6 checks passed
@robinjhuang robinjhuang deleted the limit-core-settings branch December 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webfiltered @huchenlei @robinjhuang