Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BrowserWindow into AppWindow #207

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Refactor BrowserWindow into AppWindow #207

merged 8 commits into from
Nov 8, 2024

Conversation

robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Nov 8, 2024 •
edited
Loading

Fixed some potential bugs as well:

  • Wait for renderer to send ready event before sending message to renderer (previously part of the implementation checked the "is loading" event)

Closes #145

@robinjhuang robinjhuang requested a review from huchenlei November 8, 2024 00:43
huchenlei
huchenlei approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/models/DownloadManager.ts Show resolved Hide resolved
@robinjhuang robinjhuang merged commit 2a68f14 into main Nov 8, 2024
6 checks passed
@robinjhuang robinjhuang deleted the rh-appwindow branch November 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Wrap nullable global variables into a class
2 participants
@robinjhuang @huchenlei