New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(requirements.txt): ensure typing-extensions >= 4.7.0 #61

Merged

yoland68 merged 4 commits into Comfy-Org:main from drip-art:sno-typing-ext

May 17, 2024

Member

snomiao commented May 15, 2024 •

edited

Loading

Crashed on windows with ImportError: cannot import name 'List' from 'typing_extensions' · Issue #59 · yoland68/comfy-cli


          fix(requirements.txt): ensure typing-extensions >= 4.7.0

036ef4f

Member

yoland68 commented May 15, 2024

We ship this through pyproject.toml file, the requirement should be added there as well

snomiao added 3 commits

May 15, 2024 21:14


          fix(pyproject-toml): typing-ext 4.7.0

367afd0

typing-ext 4.7.0


          fix(pyproject.toml): error: Multiple top-level packages discovered in…

75aa417

… a flat-layout: ['assets', 'comfy_cli'].

- [fix(requirements.txt): ensure typing-extensions >= 4.7.0 · 036ef4f]( https://github.com/yoland68/comfy-cli/actions/runs/9101020749/job/25019218143?pr=61 )

by https://stackoverflow.com/questions/72294299/multiple-top-level-packages-discovered-in-a-flat-layout


          Merge https://github.com/yoland68/comfy-cli into sno-typing-ext

1b8960f

yoland68 merged commit 4d85318 into Comfy-Org:main

4 checks passed

snomiao deleted the sno-typing-ext branch

May 18, 2024 07:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet