Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test on install command #110

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add test on install command #110

merged 4 commits into from
Jul 10, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jul 10, 2024 •
edited
Loading

Test install command

  • comfy --here install
  • comfy --workspace ./ComfyUI install

Reproduces #98

@huchenlei huchenlei mentioned this pull request Jul 10, 2024
Merged
@huchenlei huchenlei marked this pull request as ready for review July 10, 2024 17:53
@huchenlei huchenlei requested a review from robinjhuang July 10, 2024 17:53
@huchenlei
Copy link
Member Author

@robinjhuang PTAL

huchenlei
huchenlei commented Jul 10, 2024
View reviewed changes
comfy_cli/cmdline.py

def callback(_ctx: typer.Context, param: typer.CallbackParam, value: str):
class MutuallyExclusiveValidator:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert closure to class so internal state can be reset by test

@huchenlei huchenlei merged commit 756d377 into Comfy-Org:main Jul 10, 2024
7 checks passed
@huchenlei huchenlei deleted the test branch July 10, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjhuang robinjhuang Awaiting requested review from robinjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huchenlei