Skip to content

Commit

Permalink
Continue on update node cache error when installing ComfyUI-Manager (#…
Browse files Browse the repository at this point in the history
…208)

* Add.

* Catch errro..

* Update ruff.

* Revert.
  • Loading branch information
robinjhuang authored Nov 13, 2024
1 parent 2ff6f6e commit b2ba7d0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
8 changes: 1 addition & 7 deletions comfy_cli/command/custom_nodes/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,13 +491,7 @@ def update_node_id_cache():

new_env = os.environ.copy()
new_env["COMFYUI_PATH"] = workspace_path
res = subprocess.run(cmd, env=new_env, check=True)
if res.returncode != 0:
typer.echo(
"Failed to update node id cache.",
err=True,
)
raise typer.Exit(code=1)
subprocess.run(cmd, env=new_env, check=True)


# `update, disable, enable, fix` allows `all` param
Expand Down
5 changes: 4 additions & 1 deletion comfy_cli/command/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,10 @@ def execute(
depComp.install_deps()

if not skip_manager:
update_node_id_cache()
try:
update_node_id_cache()
except subprocess.CalledProcessError as e:
rprint(f"Failed to update node id cache: {e}")

os.chdir(repo_dir)

Expand Down

0 comments on commit b2ba7d0

Please sign in to comment.