comfy standalone: numpy < 2.0 for all OS (#202)

* Numpy < 2.0 for all OS. * Fix ruff issues. * update uv unittest to reflect numpy < 2 forced requirement --------- Co-authored-by: telamonian <[email protected]>
Comfy-Org · Oct 31, 2024 · 93ab01b · 93ab01b
1 parent 9f86f60
commit 93ab01b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/comfy_cli/uv.py b/comfy_cli/uv.py
@@ -7,9 +7,8 @@
 from typing import Any, Optional, Union, cast
 
 from comfy_cli import ui
-from comfy_cli.constants import GPU_OPTION, OS
+from comfy_cli.constants import GPU_OPTION
 from comfy_cli.typing import PathLike
-from comfy_cli.utils import get_os
 
 
 def _run(cmd: list[str], cwd: PathLike, check: bool = True) -> subprocess.CompletedProcess[Any]:
@@ -406,8 +405,6 @@ def make_override(self):
                 f.write(DependencyCompiler.overrideGpu.format(gpu=self.gpu, gpuUrl=self.gpuUrl))
                 f.write("\n\n")
 
-            # TODO: remove numpy<2 override once torch is compatible with numpy>=2
-            if get_os() == OS.WINDOWS:
                 f.write("numpy<2\n")
                 f.write("\n\n")
 

diff --git a/tests/uv/mock_requirements/requirements.compiled b/tests/uv/mock_requirements/requirements.compiled
@@ -8,7 +8,7 @@ mpmath==1.3.0
     #   -r /home/tel/git/comfy-cli/tests/uv/mock_requirements/y_reqs.txt
     #   sympy
     # from https://download.pytorch.org/whl/rocm6.1
-numpy==2.0.0
+numpy==1.26.4
     # via
     #   --override override.txt
     #   -r /home/tel/git/comfy-cli/tests/uv/mock_requirements/x_reqs.txt