Add category-based filtering in settings search #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.Locale for locale-based filtering
huchenlei
force-pushed
the
search-categories
branch
from
3a5fdd4 to
05c847d
Compare
huchenlei
approved these changes
Dec 30, 2024
huchenlei
reviewed
Dec 30, 2024
| @@ -232,14 +233,26 @@ const handleSearch = (query: string) => { | |||
| const filteredSettings = allSettings.filter((setting) => { | |||
| const idLower = setting.id.toLowerCase() | |||
| const nameLower = setting.name.toLowerCase() | |||
| const translatedName = t( | |||
| `settings.${normalizeI18nKey(setting.id)}.name` | |||
| const translatedName = st( | |||
There was a problem hiding this comment.
Switch t to st here as extension registered settings might not have translation.
huchenlei
changed the title
huchenlei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add category-based filtering in the settings dialog.
before:
after:
About Comfy.Locale
Previously, the
Comfy.Localesetting lacked a category, so it did not appear under any category filters. By adding['Comfy', 'Locale', 'Language']to its category, the setting now correctly shows up under the "Locale" category, making it easier to find and filter by language-related options.https://github.com/Comfy-Org/ComfyUI_frontend/pull/2086/files#diff-feddb5538790cf32783a1d79209f8111a1e27cb565b937d15a59c047b1b2228bR264
When you have a moment, I would appreciate it if you could review these changes. Thank you!