-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflow-insert with reroute nodes #2008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With tests, even! Thank you. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we collapse the sidebar before taking the screenshot?
Also I would like a more minimal reproduction for the example workflow used for this test to be more isolated to other features.
de3a8b0
to
b6463b5
Compare
Fix #1999: Reroute nodes cannot be be added via workflow-insert because their
onConnectionsChange
is invoked before graph is fully configured. Fix by adding the same guard other widgets have:ComfyUI_frontend/src/extensions/core/widgetInputs.ts
Lines 135 to 139 in 72f7c31
The connections are still set up correctly after the graph is configured.
┆Issue is synchronized with this Notion page by Unito