Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load 3d node support #1563

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

jtydhr88
Copy link
Collaborator

Hi,
I implemented a node to load local 3d models and output IMAGE for furthur process, such as controlnet, as reference image.
here is a demo video:
https://github.com/user-attachments/assets/703b12ed-9e60-42df-9de2-31fa1df48ce7
Need comfyanonymous/ComfyUI#5564 as BE

Copy link

socket-security bot commented Nov 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None +6 2.56 MB types
npm/[email protected] None 0 27.5 MB mrdoob

🚮 Removed packages: npm/[email protected]

View full report↗︎

src/extensions/core/load3d.ts Outdated Show resolved Hide resolved
@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Nov 17, 2024

add stl format support, also add normal and wireframe material support
image
image

@jtydhr88
Copy link
Collaborator Author

currently, the two browers tests failed but I am not sure it is caused by my changes, I checked another recent PR, like #1537, it also has such issues @huchenlei

@huchenlei
Copy link
Member

huchenlei commented Nov 17, 2024

currently, the two browers tests failed but I am not sure it is caused by my changes, I checked another recent PR, like #1537, it also has such issues @huchenlei

Sorry about that. It was introduced by accident. Please rebase your branch. The playwright test failure was fixed in #1561

@jtydhr88
Copy link
Collaborator Author

currently, the two browers tests failed but I am not sure it is caused by my changes, I checked another recent PR, like #1537, it also has such issues @huchenlei

Sorry about that. It was introduced by accident. Please rebase your branch. The playwright test failure was fixed in #1561

Done

@jtydhr88
Copy link
Collaborator Author

/home/runner/work/ComfyUI_frontend/ComfyUI_frontend/src/stores/coreSettings.ts
Error: 5:3 error 'LinkReleaseTriggerMode' is defined but never used unused-imports/no-unused-imports
One test failed on this line but likely it is caused by another change @huchenlei

@huchenlei huchenlei merged commit d5ce140 into Comfy-Org:main Nov 17, 2024
8 of 9 checks passed
@jtydhr88 jtydhr88 deleted the load-3d-node-new branch November 18, 2024 00:59
@yovsac
Copy link

yovsac commented Dec 4, 2024

This is exactly what I was looking for for a while! How can I use this node??

@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Dec 4, 2024

hi @yovsac , as you see, the FE code already merged,
However, we are still waiting for one PR in core repo comfyanonymous/ComfyUI#5564,
if you real need this feature, you might refer and just "copy" my code in comfyanonymous/ComfyUI#5564 to your local env until the PR merged

@yovsac
Copy link

yovsac commented Dec 4, 2024

Thank you for your quick reply. Im using Comfyui portable. Can you tell me how I can copy the code?

@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Dec 4, 2024

@yovsac I just realize coping code to your local env might not a good idea if you are using comfyui portable version, because I am not sure it is already included the FE code here.
However, if you really want to try this, you can follow:

  1. create a py file under your ComfyUI\comfy_extras folder, named it nodes_load_3d.py
    image

  2. copy the code from https://github.com/comfyanonymous/ComfyUI/pull/5564/files into nodes_load_3d.py

  3. edit your ComfyUI\nodes.py
    image

  4. go to init_builtin_extra_nodes() method, add one line inside extras_files,
    image

  5. then restart your ComfyUI

Still, this method may not work as your local env might not included the latest FE code.

@yovsac
Copy link

yovsac commented Dec 4, 2024

Thank you very much. I’ll try that!!

@jtydhr88
Copy link
Collaborator Author

jtydhr88 commented Dec 4, 2024

@yovsac maybe the best idea is, could you help to go the core PR comfyanonymous/ComfyUI#5564, leave your idea and may push it merge quickly?

@yovsac
Copy link

yovsac commented Dec 4, 2024

I left a message. Hope they hurry up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants