feat: Add a basic implementation of shared chat profile pictures #5760
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biggest problems with this implementation, and the ones which need to be fixed ASAP are: * It stores the URL of the profile picture on the TwitchUser class for each user, which may or may not increase the ram usage. * It uses a hard-coded replacement of the 300x300 size which is, while seemingly consistent across channels, just looks very bad. * Quite a bit of code duplication. * Some inconsistent variable naming. Besides that, from the minimal amount of testing I've done, it seems to be pretty usable.
|
edit: when a channel from the shared chat pool is also open in Chatterino, their badge is not loaded imaqtpie: disguisedtoast ✔️ emilyywang ✔️ scarra ❌ I opened emilyywang's channel while trying to figure out this problem, and her badge unloaded from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds small(ish) profile pictures next to the badges of the users, to make it easy to tell from which chat the message came from at a quick glance:
The biggest problems with this implementation, and the ones which need to be fixed ASAP are:
Besides that, from the minimal amount of testing I've done, it seems to be pretty usable.