SVG export enhancements #1277
Draft
SVG export enhancements #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to set scaling based on model dimension instead of autoscale. Change default projection to match cq-editor. Add option and set default "up" direction so it does not flip with changes to projectionDir. Remove margin from autoscale calculation when autoscale enabled. This allows margins to be edited without affecting scale.
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 94.16% 94.10% -0.07%
==========================================
Files 26 26
Lines 5451 5459 +8
Branches 925 927 +2
==========================================
+ Hits 5133 5137 +4
- Misses 188 191 +3
- Partials 130 131 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
|
Currently it is not supported to let the exporter decide the size of the image. you have set a height or width. It would be nice to let the exporter decide the height and width based on the boundingbox and the margin. All based on a unitscale of 1 instead of the 0.75. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to set scaling based on model dimension instead of autoscale.
Change default projection to match cq-editor.
Add option and set default "up" direction so it does not flip with changes to projectionDir.
Remove margin from autoscale calculation when autoscale enabled. This allows margins to be edited without affecting scale.
Resolves #729, resolves #730.