Set default throughput based on account's workload type #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2024 16:03
…o users/aisayas/tiered-onboarding
@microsoft-github-policy-service agree [company="Microsoft"] |
@microsoft-github-policy-service agree |
jawelton74
reviewed
Dec 23, 2024
| @@ -15,3 +17,9 @@ function isPrivateEndpointConnectionsEnabled() { | |||
| export function isPublicInternetAccessAllowed(): boolean { | |||
| return !isVirtualNetworkFilterEnabled() && !isIpRulesEnabled() && !isPrivateEndpointConnectionsEnabled(); | |||
| } | |||
|
|
|||
| export function getWorkloadType(): WorkloadType { | |||
There was a problem hiding this comment.
What does this return when no workload tag is present ? Can you please add unit tests for this ? Maybe we need a 'None' workload type enum ?
sunghyunkang1111
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview this branch
Customers will have the option to set the default throughput based on the account's workload type.
Learning/DevTest Cohort - Autoscale container is set to 1000 RU/s instead of 4000 RU/s
Prod Cohort - Autoscale container remains at 4000 RU/s
In the event an account does not have a workload type, the default throughput remains same as before.