Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility-1217621]: Keyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page. #1927

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satya07sb
Copy link
Collaborator

@satya07sb satya07sb commented Aug 12, 2024

This PR addresses an issue where keyboard focus is lost when navigating to the Data Explorer page from the Overview page in Azure Cosmos DB. The problem was that after activating the "Data Explorer" menu item, the page did not correctly set focus on the expected element, impairing keyboard navigation.

Preview this branch

621.mp4

…eyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page.
@satya07sb satya07sb force-pushed the accessibility-1217621 branch from 8b0dfee to e3503d2 Compare August 12, 2024 07:06
@satya07sb satya07sb changed the title [accessibility-1217621]:[Usable - Azure Cosmos DB - Data Explorer]: K… [accessibility-1217621]: Keyboard focus gets lost on the page which opens after activating "Data Explorer" menu item present under 'Overview' page. Aug 12, 2024
@satya07sb satya07sb marked this pull request as ready for review August 12, 2024 09:32
@satya07sb satya07sb requested a review from a team as a code owner August 12, 2024 09:32
@satya07sb satya07sb self-assigned this Aug 12, 2024
@sevoku
Copy link
Contributor

sevoku commented Aug 12, 2024

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

@satya07sb
Copy link
Collaborator Author

satya07sb commented Aug 12, 2024

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

As per your suggestion it will make more sense; However, the ticket specifies that the focus should be on the refresh button when opening the Data Explorer.
Ticket: accessibility-1217621

@jawelton74
Copy link
Contributor

Is there a specific reason we want to focus the refresh button initially? The first focusable element would rather be the first button in the toolbar. However from usability perspective it'd make more sense to focus the big "New Container" button, users who don't have created any container yet, can just proceed from there and others need only to hit Tab once to reach their data. Thoughts?

As per your suggestion it will make more sense; However, the ticket specifies that the focus should be on the refresh button when opening the Data Explorer. Ticket: accessibility-1217621

I agree with Sevo. Let's seek clarification from the accessibility team.

@satya07sb satya07sb marked this pull request as draft August 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants