Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Add Dedicated Gateway Type #1778

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tarazou9
Copy link
Contributor

@tarazou9 tarazou9 commented Mar 21, 2024

Why make this change?

To support distributed query on dedicated gateway.

What is this change?

  • Add a drop down for dedicated gateway type.
  • On enable dedicated gateway, user can change the value of its type.
  • Once saved and enabled, the type will be disabled.
  • When rendering an account with dedicated gateway already provisioned, the dedicated gateway type should reflect correct value.
  • Modified the blurb on the top.
  • Added tooltip for the dropdown.
    - TODO: need to update the document link in tooltip once we have it.

How was this tested?

Tested locally. Cases tested:

  1. Provisioned dedicated gateway with "Distributed Query" type successfully
    • Reload page after provisioned succeeded, value retrieved correctly.
    • Once provisioned, dropdown disabled for modification.
    • Increased the instances count, succeeded upon save.
    • Deprovisioned successfully
  2. Provisioned dedicated gateway with "Integrated Cache" type successfully
    • Reload page after provisioned succeeded, value retrieved correctly
    • Once provisioned, dropdown disabled for modification.
    • Increased the instances count, succeeded upon save
    • Deprovisioned successfully
  3. Existing sqlx accounts
    • Show Integrated Cache as default and disabled for modification.
      image
      image

@tarazou9 tarazou9 marked this pull request as ready for review April 15, 2024 18:00
@tarazou9 tarazou9 requested a review from a team as a code owner April 15, 2024 18:00
@tarazou9 tarazou9 changed the title Add Dedicated Gateway Type [DO NOT MERGE] Add Dedicated Gateway Type Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants