common.xml: Add AHRS commands #376
Conversation
|
Linked PR: |
message_definitions/v1.0/common.xml
Outdated
| <param index="6">Empty.</param> | ||
| <param index="7">Empty.</param> | ||
| </entry> | ||
| <entry value="33004" name="MAV_CMD_EAHRS_START_VG3D_CLB_IN_FLIGHT" hasLocation="false" isDestination="false"> |
There was a problem hiding this comment.
Sorry, it's internal naming for magnetometer calibration
It's Ok, if I name this
MAV_CMD_EAHRS_START_MAG_CLB_IN_FLIGHT
MAV_CMD_EAHRS_STOPT_MAG_CLB_IN_FLIGHT
?
There was a problem hiding this comment.
Yep, if it's generic that's preferred. From what I know, we avoid vendor specific packets or vendor specific acronyms in the common.xml
There was a problem hiding this comment.
I removed these magnetometer calibration commands from this PR
If this PR will be merged I plan to open the new one with "magnetometer calibration" commands/handler
valbv
force-pushed
the
eahrscommands
branch
2 times, most recently
from
7db3aca to
934bdc1
Compare
message_definitions/v1.0/common.xml
Outdated
| <!-- AHRS commands (32000 to 32099) --> | ||
| <entry value="33000" name="MAV_CMD_AHRS_START" hasLocation="false" isDestination="false"> | ||
| <description>Send command "start data sending" to the AHRS</description> | ||
| <param index="1">Empty.</param> |
There was a problem hiding this comment.
param1 should be an instance number, allowing the user to enable/disable specific backends.
message_definitions/v1.0/common.xml
Outdated
| <param index="7">Empty.</param> | ||
| </entry> | ||
| <entry value="33002" name="MAV_CMD_AHRS_ENABLE_GNSS" hasLocation="false" isDestination="false"> | ||
| <description>Send command "enable GNSS" to the AHRS</description> |
There was a problem hiding this comment.
| <description>Send command "enable GNSS" to the AHRS</description> | |
| <description>Enable GPS use by the AHRS</description> |
etc
message_definitions/v1.0/common.xml
Outdated
| @@ -2218,6 +2218,47 @@ | |||
| <param index="6">Empty.</param> | |||
| <param index="7">Empty.</param> | |||
| </entry> | |||
| <!-- AHRS commands (32000 to 32099) --> | |||
| <entry value="33000" name="MAV_CMD_AHRS_START" hasLocation="false" isDestination="false"> | |||
| <description>Send command "start data sending" to the AHRS</description> | |||
There was a problem hiding this comment.
| <description>Send command "start data sending" to the AHRS</description> | |
| <description>Send command "start data sending" to the AHRS</description> |
would be nice to find some neutral term for this. If we were to try to apply this to DCM or EKF, how would we term that operation?
Also... why would we want to do this? The answer to that might inform a better phrase here.
Hi, I thought about making a MAV_CMD_EAHRS_CMD message and passing the flag to the corresponding specific command.
But then when adding other commands I came across a situation where I needed to pass group of parameters.
For example, for the EAHRS "aiding data" commands.
Therefore, I made a separate message for each command.