common.xml: add new frame MAV_FRAME_GLOBAL_VEHICLERELATIVE_ALT #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2024
Closed
|
TBH, I think this just adds more complexity than it's worth. Let's make the vehicle accept a takeoff command to a specific alt-vs-home, alt-vs-terrain or alt-vs-sea-level instead of adding a new frame to match what the code does now. I just worry that if we add this frame here then we will need to add it to every mission command we support. |
this is expected to be used to tell a vehicle to take off to 20m above current altitude. ArduPlane already actually does this for some commands, but uses an inappropriate altitude frame. Should also be useful for "go up 20m".
peterbarker
force-pushed
the
pr/VEHICLERELATIVE_ALT
branch
from
cf30c42 to
d32bba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is expected to be used to tell a vehicle to take off to 20m above current altitude.
ArduPlane already actually does this for some commands, but uses an inappropriate altitude frame.
Should also be useful for "go up 20m".