HAL_ChibiOS: Added support for GreenSight's UltraBlue flight controller #28995
+1,465
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
reviewed
Jan 4, 2025
| # PWM AUX channels | ||
| # NOTE: PWM outputs on the same channel must all have | ||
| # the same output protocol (DShot, PWM, etc) | ||
| PH10 TIM5_CH1 TIM5 PWM(1) GPIO(50) |
There was a problem hiding this comment.
You will want BIDIR for at least the first for channels, so put it on PWM1 and PWM3
andyp1per
reviewed
Jan 4, 2025
| OSCILLATOR_HZ 16000000 | ||
|
|
||
| # Board ID for firmware load | ||
| APJ_BOARD_ID 1071 |
There was a problem hiding this comment.
You need to allocate your own number in board_types.txt
Hwurzburg
reviewed
Jan 4, 2025
There was a problem hiding this comment.
A few things upon cursory review that need answers before I do a thorough review:
- The photo does not indicate the "mezzanine" connector, or its type
- The defaults.param file should only have the SERVOx_FUNCTION items, all others belong in the hwdef
- Once you get a board id assigned in a separate PR, use its text description in the .dat files
- Need bootloader file added
- No SD card slot shown in photo...consider adding SD in bootloader for firmware load from SD
- Boot switch is not indicated in photo....what is the initial firmware? ArduPilot?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.