Plane: ATT.DesPitch now reports actual target, not nav output #28991
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the logged quantity in
ATT.DesPitch
fromPlane::nav_pitch_cd
to the target value that actually gets passed to the pitch controller.Details
Logging
Plane::nav_pitch_cd
inATT.DesPitch
gives the false impression that there's steady-state error in the pitch controller.This PR improves log readability, as it already includes
PTCH_TRIM_DEG
and the contribution ofKFF_THR2PTCH
.Plane::nav_pitch_cd
is already logged inCTUN
.Testing
sim_vehicle.py
was spun up andPTCH_TRIM_DEG=3
was set.TAKEOFF mode was armed.
Before:
ATT.DesPitch
andCTUN.NavPitch
overlap.Steady-state error is falsely logged.
After:
The three pitch quantites are clearly discernible.