Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: add MicoAir743 to manifest generator #28935

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tools: add MicoAir743 to manifest generator #28935

wants to merge 1 commit into from
+1 −0

Conversation

Minderring
Copy link
Contributor

add MicoAir743 to Tools/scripts/generate_manifest.py

peterbarker
peterbarker requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

Should also be Tools:, not scripts:

@Minderring Minderring changed the title scripts: add MicoAir743 to manifest generator Tools: add MicoAir743 to manifest generator Jan 3, 2025
@Minderring Minderring force-pushed the pr-scripts-add-MicoAir743 branch from fa055db to 4841a8d Compare January 3, 2025 03:54
@Minderring
Copy link
Contributor Author

Needs a rebase

Should also be Tools:, not scripts:

Rebased and corrected it as Tools:, Please review it. @peterbarker

@Minderring Minderring requested a review from peterbarker January 3, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker Awaiting requested review from peterbarker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Minderring @peterbarker