Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ConversationStore to follow SettingsStore pattern #5881

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Dec 28, 2024

This PR refactors the ConversationStore class to follow the same pattern as SettingsStore:

  • Make ConversationStore an abstract base class
  • Create FileConversationStore implementation
  • Move ConversationMetadata to server.data_models
  • Reorganize storage package structure

All usages of ConversationStore.get_instance have been updated to use the implementation and supply a token similar to SettingsStoreImpl.get_instance.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2fc946f-nikolaik   --name openhands-app-2fc946f   docker.all-hands.dev/all-hands-ai/openhands:2fc946f

- Make ConversationStore abstract base class
- Create FileConversationStore implementation
- Move ConversationMetadata to server.data_models
- Reorganize storage package structure
@tofarr tofarr marked this pull request as draft December 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants