Fix s3 bucket reference #5867
Open
Fix s3 bucket reference #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it feels weird to reuse |
|
If we rename the setting, it affects user installations, it invalidates what they set. I'm not sure about this, sorry. It's alleviated by the fact that docker app users only use it since recently, but on the other hand it broke, and it would break again. 🤔 It seems with this solution, we still use a AWS_S3_BUCKET var, and a FILE_STORE_BUCKET var as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FILE_STORE_PATH is always set and if S3 is the FILE_STORE type then FILE_STORE_PATH will have the S3 bucket name. There is no need for a separate S3 bucket variable.