Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging agent loops #5853

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix hanging agent loops #5853

wants to merge 2 commits into from

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 27, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

If you create a new conversation, but the webhook never attaches, the agent loop gets orphaned and never gets cleaned up.

With this change, we call cleanup when the loop gets created, so that if no one connects after 15s it gets abandoned

Working on something more robust here as well


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:993b158-nikolaik   --name openhands-app-993b158   docker.all-hands.dev/all-hands-ai/openhands:993b158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant