Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime size configuration feature #5805

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Dec 26, 2024

This PR adds a new feature to configure the runtime size in the settings modal. Users can now choose between 1x (2 core, 8G) and 2x (4 core, 16G) options.

Changes include:

  • Added a new REMOTE_RUNTIME_RESOURCE_FACTOR field to the Settings type
  • Created a new RuntimeSizeSelector component
  • Updated the SettingsForm component to include the new selector
  • Modified getSettings and saveSettings functions to handle the new setting
  • Updated tests to include the new setting
  • Added documentation about the new runtime size option in the README.md file

Please review and let me know if any changes are needed.


Notes:

  1. Fixes [Feature Request]: Set RemoteRuntime size in frontend #5797
  2. This is pending review by @neubig

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d5981a3-nikolaik   --name openhands-app-d5981a3   docker.all-hands.dev/all-hands-ai/openhands:d5981a3

@neubig neubig marked this pull request as draft December 26, 2024 00:43
@neubig neubig self-assigned this Dec 26, 2024
@neubig neubig removed the lint-fix label Dec 29, 2024
Copy link
Contributor Author

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, @amanape it'd be great if you could do a second review.

@neubig neubig requested a review from amanape December 29, 2024 05:20
@neubig neubig assigned amanape and unassigned neubig Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Set RemoteRuntime size in frontend
3 participants