Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #255 Disable file extension check entirely #2552

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aweis89
Copy link

@aweis89 aweis89 commented Dec 7, 2024

Currently there's a filter where --watch-file doesn't work for file's that don't match the list of static extensions.
The issue is:

  • I'd assume users would prefer to be able to use this feature with files that have different comment styles (using a currently supported format) even if it's not a technically valid comment rather than not be able to use this feature at all
  • Files like .zshrc which don't conform to the extension check would need to have separate logic for checking the filename
  • Having to list all extensions and exceptions seems like overly burdensome

Fixes #2550

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2024

CLA assistant check
All committers have signed the CLA.

@paul-gauthier
Copy link
Collaborator

This is something I have been considering. Let me think on it. I worry that it may have unintended consequences.

@aweis89
Copy link
Author

aweis89 commented Dec 7, 2024

This is something I have been considering. Let me think on it. I worry that it may have unintended consequences.

I was wondering about this as well. However, based on the assumption that aider would only consider newly added comments, I figured that would further limit the potential unintended consequences. Would a user indeed have to add an AI comment to a file after triggering aider for it to be considered? I was also wondering if maybe a '--watch-ignore' should be added to exclude various path?

@umutcanoner
Copy link

umutcanoner commented Dec 8, 2024

I believe this might be better. I, for one, utilize aider not only as a coding tool. I use it a lot while working on large markdown documents, frontend files; even files without file extensions.
edit: I remember utilizing aider while working on my travel visa even.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch file doesn't work for .zsh or .zshrc files
4 participants