Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perturbed-Attention Guidance toggle. #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FeepingCreature
Copy link
Contributor

@FeepingCreature FeepingCreature commented Apr 16, 2024

See https://ku-cvlab.github.io/Perturbed-Attention-Guidance/

I worry this is following a bad precedent with the SAG PR, of which it is a copypaste. The issue is that, in testing, once again it didn't really make images look unconditionally better for me, so much as different - but different in a different fashion than SAG!

(This raises fun questions, such as "what is the correct node order between PAG and SAG". I shall not answer them.)

I mostly want to have this PR out here in case people want to play around with it.

@Acly
Copy link
Owner

Acly commented Apr 17, 2024

I tried it out some. This one is a bit more interesting. It can give some dramatic changes for the better when you don't use a prompt. Usually that's not super useful, but at lower denoise strength it can be used as a sort of "repair" to fix & clean up images without having to describe them. The question is how to integrate that in way it can be discovered rather than hidden toggle.

For regular prompted workflows it just sort of changes them a bit... more impact than SAG but yes, not always better. Still costs 30% performance too.

@FeepingCreature FeepingCreature force-pushed the add-pag-toggle branch 2 times, most recently from 65f3834 to 7cc94f5 Compare June 21, 2024 18:49
@FeepingCreature FeepingCreature force-pushed the add-pag-toggle branch 2 times, most recently from 1500c7d to e16de3a Compare July 2, 2024 21:20
@FeepingCreature FeepingCreature force-pushed the add-pag-toggle branch 2 times, most recently from 31e1e3c to 625b6d8 Compare July 15, 2024 00:16
@LeF0URBE
Copy link

i'm watching this with interest. PAG manage to fix some of my weak Lora influence most of the time. beter than FreeU in most case.
didn't find a way of combining the two in a predictable way (SDXL only test).
maybe an advanced/experimental tab would be appreciated for such cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants