Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comfyui manager download path #618

Closed
wants to merge 1 commit into from
Closed

Conversation

nzlov
Copy link

@nzlov nzlov commented Nov 24, 2023

Fix comfyui manager not downloading to export directory

Copy link

@artibex artibex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hade a issue with installing custom nodes. This fixed it.

@66li
Copy link
Contributor

66li commented Nov 27, 2023

Wouldn't it be better to have a separate directory for checkpoints?

@66li
Copy link
Contributor

66li commented Nov 27, 2023

Wouldn't it be better to have a separate directory for checkpoints?

And config.

@66li
Copy link
Contributor

66li commented Nov 27, 2023

@GinIsTheAnswer
Copy link

https://github.com/AbdBarho/stable-diffusion-webui-docker/blob/master/services/comfy/extra_model_paths.yaml It seems to be controlled by this

Does that file even do anything? It gets copied (twice), but the entrypoint doesn't use it?

@AbdBarho
Copy link
Owner

AbdBarho commented Jan 1, 2024

Hey, sorry for being late on this, I did an update in #603, maybe this has an effect or fixes the issue.

I am planning on simplifying the entire mount structure for all UIs since they are making it very hard to maintain, so maybe your problem could also be solved by this refactoring.

https://github.com/AbdBarho/stable-diffusion-webui-docker/blob/master/services/comfy/extra_model_paths.yaml
This is file is loaded by the comfy UI to know where to look for the model files.

@AbdBarho AbdBarho added the awaiting-response Waiting for the issuer to respond label Jan 1, 2024
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 16, 2024
@RyzeNGrind
Copy link

Hey I was also looking for some documentation to understand how the models, config, extensions can be saved to be used by the 3 UIs as much as possible. Instead of having separate paths specified to each interface.

@github-actions github-actions bot removed the Stale label Jan 18, 2024
Copy link

github-actions bot commented Feb 1, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 1, 2024
@RyzeNGrind
Copy link

Not stale. Still looking for documentation on sharing models and resources uniformly across the 3 GUIs.

@github-actions github-actions bot removed the Stale label Feb 2, 2024
@AbdBarho
Copy link
Owner

AbdBarho commented Feb 3, 2024

Hey @RyzeNGrind, I understand that you want to share models between the UIs as much as possible.

Unfortunately, it is causing a noticeable maintenance overhead on my side to keep everything aligned, especially since I don't maintain any of the 3 UIs and stuff keeps changing underneath.

I want to do some poll to understand what the users want / need to decide on the future structure.

Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 18, 2024
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Waiting for the issuer to respond Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants