Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated Sysinfo #16755

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Authenticated Sysinfo #16755

wants to merge 1 commit into from

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 27, 2024

Description

previously the the internal /internal/sysinfo /internal/sysinfo-download routes are not authenticated

I think AUTO's intention was that so the same API can be reused

but this has lead to a security issue in the past and could lead to more in the future if not already
so to be safe it's better that these routes require authenticated

this PR changes how sysinfo tabs downloads sysingo, using javascript button clicks and gradio calls
(as opposed to browser to API calls)
the Sysinfo tab no longer no longer relies on the APU
the existing /internal/sysinfo /internal/sysinfo-download are moved to models.api for backwards compatibility and has authentication apply to them

and as an extra benefit there's now a progress effect on the HTML while retrieving sysinfo

tested to work in Chrome and Firefox

Screenshots/videos:

firefox

download json

2024-12-27.11_20_35_974.firefox.mp4

open in tab

2024-12-27.11_20_54_880.firefox.mp4

Checklist:

@w-e-w w-e-w force-pushed the Authenticated-Sysinfo branch from 2e1e35a to c7b3fcb Compare December 27, 2024 02:53
@w-e-w w-e-w marked this pull request as draft December 27, 2024 03:03
@w-e-w w-e-w marked this pull request as ready for review December 27, 2024 03:35
@w-e-w w-e-w marked this pull request as draft December 27, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant