Use gr.Dropdown for Image Formats

[Haoming02]

Description

• Simple Description: Currently, the setting for the image formats is a Textbox, without any validation for it afaik during my brief tracing. So if the user made a typo or entered an unsupported format, it would simply raise errors when saving images.

  • (I just checked, apparently entering .png will still save without errors, with the filename simply being <filename>..png; But surely this would cause problems somewhere else?)

• Summary of Changes: Added gr.Dropdown to the options, with a list of supported formats as the choices

Checklist

• I have read contributing wiki page
• I have performed a self-review of my own code
• My code follows the style guidelines
• My code passes tests

[Haoming02]

Questions

1. Should we use gr.Dropdown or gr.Radio component (live_previews_image_format is using Radio)?
2. If using gr.Dropdown, should we also enable allow_custom_value?
3. Should we have a central list of all supported formats in somewhere like images.py
   • And have I missed any formats?

[w-e-w]

I change it to use DropdownEditable
even though it's not recommended it is technically possible someone may want to use other formats
for example gif bmp

if they require other formats I think it's better for them to convert the file to the format afterwards
but since it was possible for them to set it to format to any supported format, it should still be possible after this usability change

---

I'm not too happy with my wording about manual input of other formats
any suggestions?

[Haoming02]

How about:

.link("PIL docs", "https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html")
.info("manual input of other formats is possible, but compatibility is not guaranteed")

[w-e-w]

which do you think it's better
A

B

my opinion (read after you decide)

I think B is be better because unlike other things like Images filename pattern which links to a important Wiki
other file format this is a advance functionality that most people don't really need to know

[Haoming02]

Oh right, I forgot custom .html() is a thing

Definitely B. imho

[w-e-w]

LGTM
you any last minute changes?

[Haoming02]

LGTM too 👍