fix passing of literal backslash #16671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catboxanon
approved these changes
Nov 21, 2024
Panchovix
added a commit
to Panchovix/stable-diffusion-webui-reForge
that referenced
this pull request
Nov 21, 2024
bluelovers
added a commit
to bluelovers/stable-diffusion-webui
that referenced
this pull request
Nov 26, 2024
* dev-a1111: fix passing of literal backslash (AUTOMATIC1111#16671) fix prompt-bracket-checker miscounting of literal tokens (AUTOMATIC1111#16669) Bump safetensors to v0.4.5 Honor lossless webp compression option in API use shared.hf_endpoint (AUTOMATIC1111#16611) Warn if WebUI is installed under a dot directory (AUTOMATIC1111#16584) sd_xl_v.yaml: use_checkpoint = False XYZ option to disable grid (AUTOMATIC1111#16416) Fix Default system None filter logic (AUTOMATIC1111#16309) Fix weighting config for SDXL v-pred InputAccordion duplicate elem_id handling (AUTOMATIC1111#16381) addEventListener {passive: false} (AUTOMATIC1111#16575) pyenv-win compatibility - another approach (AUTOMATIC1111#16287) Disable Hires checkpoint if same as First pass checkpoint (AUTOMATIC1111#16269) Fix postprocessing_enable_in_main_ui ScriptPostprocessing elem_id (AUTOMATIC1111#16373) extra_only / main_ui_only ScriptPostprocessing (AUTOMATIC1111#16374) Allow newline in Extra Network activation text (AUTOMATIC1111#16428) image embedding data cache (AUTOMATIC1111#16556) Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in that PR I forgot to account for literal escape character
\\(double backslash)\\or even number of\\like\\\\is literal\and not be treated as escape characterstable-diffusion-webui/modules/prompt_parser.py
Line 381 in 82a973c
Screenshots/videos:
current after #16669
notice that it dose not cycle between error and pass as
\is added2024-11-21.09_25_36_210.chrome.mp4
this PR
correctly psychos between error and pass as
\is added2024-11-21.09_21_09_816.chrome.mp4
Checklist: