Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move clip skip sdxl option to sdxl section #16592

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

move clip skip sdxl option to sdxl section #16592

wants to merge 1 commit into from
+1 −1

Conversation

dhwz
Copy link
Contributor

@dhwz dhwz commented Oct 26, 2024

Description

  • just moves the clip skip sdxl setting to the sdxl config subsection

Screenshots/videos:

Checklist:

@w-e-w
Copy link
Collaborator

w-e-w commented Oct 26, 2024 •
edited
Loading

while I think it makes sense I also like some opinion from other people

reason to merge

  • SDXL setting should be put in SDXL section

reason to not merge

  • CLIP settngs should be put together in one place
    • as currently it's grouped with CLIP_stop_at_last_layers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-e-w w-e-w w-e-w approved these changes

@AUTOMATIC1111 AUTOMATIC1111 Awaiting requested review from AUTOMATIC1111 AUTOMATIC1111 is a code owner

@catboxanon catboxanon Awaiting requested review from catboxanon catboxanon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhwz @w-e-w