-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dragdrop for URLs to read infotext #15262
Support dragdrop for URLs to read infotext #15262
Conversation
If the request is made and fails, there should be some form of feedback, at least output to console (but possibly also |
update: drag and drop if a user already opens the URL in the browser tab they can just drag the image personally I don't see this being too useful as the user is unlikely to know what a without opening the image security issue in my opinion if this were to be implemented the web request should be made by the Client using JavaScript and not server on side
|
This hadn't occurred to me actually. I ran into that over a year ago when making a userscript though. I think this is a case where Firefox follows the browser spec but Chrome doesn't, annoyingly.
I agree with this. I admittedly implemented it server-side since it was the path of least resistance in this case. Thanks for the feedback. I'll close this PR and open a new one when I get a chance to address all this. |
Nice, that's much better. I'll just add some error handling to this now. |
Description
Adds the ability to drag and drop URLs (like an address from the browser address bar) or images that originate from URLs. The usecase for this is dragdropping images from another website or another browser instance of the webui to read the infotext.
Update: this now works on the frontend rather than the backend to avoid some potentially security issues.
Screenshots/videos:
Example with dragdropping between two separate browser windows.
Checklist: