Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this makes Lora result better but definately needs peer review #14909

Closed
wants to merge 1 commit into from
Closed

Conversation

simonmcnair
Copy link

Description

I've been using parse_generation_parameters in my own python project to decode parameters and found that it returns loras with a dangling '>'. I think this will fix it. Needs peer review though as my regex isn't great.

Screenshots/videos:

Checklist:

@simonmcnair
Copy link
Author

didn't do dev branch

@simonmcnair
Copy link
Author

I don't even know why I did this. parse_generation_parameters doesn't even parse the prompt. I must have had a brainfart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant