Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Functionality for IPv6 using Command Line Args #14310

Closed
wants to merge 0 commits into from
Closed

Added Functionality for IPv6 using Command Line Args #14310

wants to merge 0 commits into from

Conversation

ranareehanaslam
Copy link
Contributor

@ranareehanaslam ranareehanaslam commented Dec 15, 2023

Description

I have Added Functionality for IPv6 using Command Line Args
Just have to use --IPv6 to enable Gradio Listen Request on IPv6

Verified:

this Pull Request have been verified and tested on Multiple Systems

Checklist:

@ranareehanaslam
Copy link
Contributor Author

Added Functionality for IPv6 using Command Line Args --ipv6
kindly check and Merge This Thanks

@sALTaccount
Copy link

do not mass ping everybody in the discord server :1984:

Comment on lines 13 to 14
if cmd_opts.ipv6:
return "[::]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not override server_name. If anywhere, it should be in the else branch where a global listen address is being computed for cmd_opts.listen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not override server_name. If anywhere, it should be in the else branch where a global listen address is being computed for cmd_opts.listen.

this is same for listen mapping to ipv6 as well

@akx
Copy link
Collaborator

akx commented Dec 15, 2023

This PR is also targeting the wrong branch. It needs to target dev, not master.

@ranareehanaslam
Copy link
Contributor Author

do not mass ping everybody in the discord server :1984:

alright thanks

@AUTOMATIC1111
Copy link
Owner

Functionally, the proposed --ipv6 flag is the same as running with --server-name [::], which user can already do. I am against this change.

@ranareehanaslam
Copy link
Contributor Author

Functionally, the proposed --ipv6 flag is the same as running with --server-name [::], which user can already do. I am against this change.

That never worked i have tried on multiple systems and also when you deploy that into container it's not working have tried and tested multiple times you can try demo testing creating container and pass hy command line arguments and it will not work

@AUTOMATIC1111
Copy link
Owner

Can anyone else confirm this? From what I see any code, this shouldn't be the case.

@ranareehanaslam
Copy link
Contributor Author

I have tried multiple times inside docker by just passing the server name as [::] but it always listen to 127.0.0.1 not the ipv6

@chrme
Copy link

chrme commented Dec 17, 2023

this PR is useless, you just need to pass correctly ipv6 loopback address, [::1], not [::]
set COMMANDLINE_ARGS=--server-name [::1] --api

Running on local URL:  http://[::1]:7860

To create a public link, set `share=True` in `launch()`.

netstat

 TCP    [::1]:7860             [::]:0                 LISTENING

@ranareehanaslam
Copy link
Contributor Author

ranareehanaslam commented Dec 17, 2023 via email

@chrme
Copy link

chrme commented Dec 18, 2023

ok, then what if you try with set COMMANDLINE_ARGS=--server-name [::0] --api ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants