-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Functionality for IPv6 using Command Line Args #14310
Conversation
Added Functionality for IPv6 using Command Line Args --ipv6 |
do not mass ping everybody in the discord server :1984: |
modules/initialize_util.py
Outdated
if cmd_opts.ipv6: | ||
return "[::]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not override server_name
. If anywhere, it should be in the else branch where a global listen address is being computed for cmd_opts.listen
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not override
server_name
. If anywhere, it should be in the else branch where a global listen address is being computed forcmd_opts.listen
.
this is same for listen mapping to ipv6 as well
This PR is also targeting the wrong branch. It needs to target |
alright thanks |
Functionally, the proposed |
That never worked i have tried on multiple systems and also when you deploy that into container it's not working have tried and tested multiple times you can try demo testing creating container and pass hy command line arguments and it will not work |
Can anyone else confirm this? From what I see any code, this shouldn't be the case. |
I have tried multiple times inside docker by just passing the server name as [::] but it always listen to 127.0.0.1 not the ipv6 |
this PR is useless, you just need to pass correctly ipv6 loopback address, [::1], not [::]
netstat
|
But i have to use [::] so it's bounded everywhere
…On Sun, 17 Dec 2023, 8:56 pm nik, ***@***.***> wrote:
this PR is useless, you just need to pass correctly ipv6 loopback address,
[::1], not [::]
set COMMANDLINE_ARGS=--server-name [::1] --api
Running on local URL: http://[::1]:7860
To create a public link, set `share=True` in `launch()`.
netstat
TCP [::1]:7860 [::]:0 LISTENING
—
Reply to this email directly, view it on GitHub
<#14310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXJW3LLH2VF7SFVNVOHPULYJ4I2RAVCNFSM6AAAAABAWBMFZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGIYDQOJSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ok, then what if you try with |
Description
I have Added Functionality for IPv6 using Command Line Args
Just have to use --IPv6 to enable Gradio Listen Request on IPv6
Verified:
this Pull Request have been verified and tested on Multiple Systems
Checklist: