-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Upgrade to Gradio 4.0+ #14068
Comments
I wholeheartedly support this, the ImageEditor seems like a great improvement that many people were waiting for (especially an eraser for the Masking tool that got requested many times and users were always directed to ask Gradio to add it, well now they have :D ). So the minimum version for the upgrade should be 4.5.x as it seems that's when it has been introduced. Here's a demo video of the new ImageEditor from the changelog: gradio-imgeditor.mp4 |
AUTO hasn't voiced his opinion on this, this is just my opinion I have been trying to get greadio 4.x working with webui but haven't succeeded yet
at this point I feel either we need to write a compatibility layer or lots of things have to be rewritten I highly doubt we will switch to gradio 4.x in the next release |
Yes indeed there are quite a few changes, if it helps, I'll explain some of the motivation for these changes:
Previously, if a user passed an invalid argument to a component class, we would allow it and then raise a deprecation warning. Now, we've removed **kwargs since there's no advantage to allowing unsupported arguments and prevents accidental typos etc.
We've made some internal refactors to the classes to simplify file management and make it a bit easier for people to create custom components, but this shouldn't affect the public facing API for creating custom components. Let me know if you have questions / concerns here and we'll do what we can to mitigate.
In place of
The only difference is that now |
yeah I kind of understand some of those changes |
Can I have to upgrade gradio to version 4.0 from version 3.41.2 which I see in A1111 v1.6.1? |
It will probably break, yeah. |
My two cents as an extension developer: I don't think it's reasonable to prioritize extension compatibility over keeping up with Gradio updates. I have a few reasons for thinking this:
So as nice as it would be to go to sleep knowing that my code will automatically work with the next WebUI update, I don't think it's worth the effort. I'd rather see the WebUI team focus on improving the core experience than on writing countless abstraction layers that developers may or may not use. |
The responsibility for maintaining compatibility with WebUI should fall on the extension developers, not the other way around. Take, for example, a situation where WebUI receives a significant update that enhances the interface's stability and security. However, this update leads to incompatibility with several popular extensions. In this scenario, even though the update temporarily results in fewer functionalities due to the disabled extensions, the benefit of having a more stable and secure UI outweighs the drawbacks. This situation is akin to the bug in the 'masking' session of the regional prompt, which is related to gradio. In the long run, it's more beneficial for users to have a solid and reliable base platform, and it's up to the extension developers to adapt and maintain compatibility. Therefore, while we acknowledge the complexity involved in extension development, the priority should be maintaining the functionality and efficiency of the WebUI itself. But that's just the opinion of a regular user like me. |
I hope this happens soon... there are some nice things that Gradio 4 can do that v3 can't. |
Support in #14184 is expected to be merged when gradio-app/gradio#7591 is resolved. |
Cool we're going to get in a bunch of fixes for the ImageEditor this week |
I hope this happens!
|
|
Is there an existing issue for this?
What would your feature do ?
Hello folks! This is Abubakar, one of the maintainers of Gradio. We recently released Gradio 4.0 with significant more flexibility in building Gradio apps, such as the ability to create fully-custom Gradio components (see 4.0 highlights here).
I'd like to suggest that Automatic1111 WebUI upgrade to the latest version of Gradio, as 4.0 solves many annoying bugs when using Gradio within the WebUI. For example, this issue #13292 is fixed in Gradio 4.x
In addition, Gradio 4.x offers several improvements that many be beneficial to the users of the WebUI. Just a couple of examples:
Image
andImageEditor
component with improved UI/UX, e.g. theImage
component supports native clipboard-paste and theImageEditor
component provides a much nicer UX when sketching, cropping, or performing any sort of basic manipulation of images.Our plan with Gradio 4.x is to be backwards compatible not just with Gradio's core components, but also any Custom Components that are created on top of Gradio. This should make it much easier to upgrade the Gradio dependency within 4.x much easier if the WebUI would like to in the future.
Being a major version release, Gradio 4.x does include breaking changes from Gradio 3.x. These are listed here along with migration tips, and we're happy to offer specific suggestions on how to migrate any other code from Gradio 3.x to 4.x.
Proposed workflow
Bumping the gradio dependency to the latest 4.x version
Additional information
No response
The text was updated successfully, but these errors were encountered: