Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken in webui dev branch and add extension to index #10

Closed
w-e-w opened this issue Nov 23, 2023 · 3 comments
Closed

broken in webui dev branch and add extension to index #10

w-e-w opened this issue Nov 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@w-e-w
Copy link

w-e-w commented Nov 23, 2023

two things

adding extension index

I was made aware of this extension by a comment so I want to add it the index

please check if this looks okay to you AUTOMATIC1111/stable-diffusion-webui-extensions#234


broken in webui dev branch

one thing that I do before adding an extension is I will test the extension

what I found out is that it seems the extension is broken in the current dev branch but working in 1.6.1 master
with my very limited JavaScript experience I believe the issue is due to your MutationObserver not firing

new MutationObserver((_, observer) => {

since the dev branch is changing I'm not sure if this issue would be fixed automatically in the future, but I think making you aware of the issue before hand might be good

@huchenlei
Copy link
Owner

I think the issue is a DOM structure change that renders the new progress element under #txt2img_results_panel instead of #txt2img_results. I will submit a fix later.

@huchenlei huchenlei added the bug Something isn't working label Nov 23, 2023
@w-e-w
Copy link
Author

w-e-w commented Nov 23, 2023

I think the issue is a DOM structure change that renders the new progress element under #txt2img_results_panel instead of #txt2img_results. I will submit a fix later.

I would hold on a bit not sure what AUTO would do
see AUTOMATIC1111/stable-diffusion-webui#14068
my guess is that if we move gradio 4.0+ more things will break

@huchenlei
Copy link
Owner

Temp fix submitted 3db2b44. I will keep an eye on A1111 changes to gradio 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants