SD Simple Dimension Preset

[gutris1]

Info

https://github.com/gutris1/sd-simple-dimension-preset

Checklist:

• I have read the Readme.md
• The description is written in English.
• The index.json and extension_template.json have not been modified.
• The entry is placed in the extensions directory with the .json file extension.

[w-e-w]

again here your description is being used as readme documentation it is not supposed to be a documentation

don't copy your readme

• sd-hub #394 (comment)

[w-e-w]

also PR to fix to an issue

• fix issue with using fetch gutris1/sd-simple-dimension-preset#3

[w-e-w]

one suggestion

I want to be clear that this is a personal "suggestion" NOT a requirement / issue

yor are using --primary-500 for the SVG icon color
in my opinion this does not work that well on the themes I tested
it stands out quite a lot and very different from the switch width / height Icon below it
I would suggest that you use the same color color as the icon whitch is --button-secondary-text-color

hear is side by side comparisons of 3 themes ligh and dark mode
I was suggest that you test more themes to see what works best

--primary-500	--button-secondary-text-color

[gutris1]

one suggestion

I want to be clear that this is a personal "suggestion" NOT a requirement / issue

yor are using --primary-500 for the SVG icon color in my opinion this does not work that well on the themes I tested it stands out quite a lot and very different from the switch width / height Icon below it I would suggest that you use the same color color as the icon whitch is --button-secondary-text-color

hear is side by side comparisons of 3 themes ligh and dark mode I was suggest that you test more themes to see what works best

--primary-500 --button-secondary-text-color

haha, I only tested it with nocrypt theme and gradio default
I'll change it

[gutris1]

thanks a lot.

[w-e-w]

I change the script tag to UI related
like most other Aspect Ratio extentions

[gutris1]

hey @w-e-w , if I may
whats your opinion on this one? https://github.com/gutris1/sd-image-viewer

[w-e-w]

my opinion
it's a gigantic block of code with no descriptions apart from a title and a screenshot
and commit messages only readable by people who understand emoji

yes I am a bit pissed

if you want to actually give feedback about your code, you will want to give adequate information making other people's life easier

---

after reading the WALL OF TEXT bit, and determined that it seems to be only DOM manipulations
and so should be safe to execute, I then installed your extension on my system

it "SEEMS" to work that is ALL I can say
I can't know if it's actually working because I didn't bother entire reading the code
there could be some important functionality not working, but because it's not working I don't see it working so I don't know if it's working or not

all "I know" is that I "LOSE" functionality such as the ability to toggle live preview
and maybe I find tiling very useful because I make textures
did you deliberately hide them I don't know?
I don't know
no documentations

!!! provide documentation before asking people to review !!!

otherwise people won't even know that this is supposed to be a full screen image viewer that replaces the

I know what this is because I recognize some of the code that you use such as lightboxModal

---

BUG

you forgot to decode the downlaod file names from URL encoding
20241228-013828-535525%203167095102%201ea5.png -> 20241228-013828-535525 3167095102 1ea5.png

---

for you info there is this https://github.com/viyiviyi/stable-diffusion-webui-zoomimage

I'm not saying this extension is perfect
I personally have one issue with it, I don't like the image that's not take up the full height of the window
but this can be fix by removeing a single line I have done so in my fork

if you're asking about submitting to the index then
currently your extension seems to basically the basically exact same thing as the existing extension but just with a several UI differences
and in general I don't really like to add extensions that do basically the same thing
I would prefer that people help maintain and improve existing extensions

if you thinks that your version is substantially better then I can consider added to the index
but you have to convince me why it is better and why not improve on existing extension (so that people that are using them can also get the improvements), such as may be your extension having extra functionality

[w-e-w]

okay you do know about https://github.com/viyiviyi/stable-diffusion-webui-zoomimage
I missed the tiny link at the bottom of your readme

[w-e-w]

you're welcome to submit extensions for review
but don't be like "here is a wall of text, what do you think?"

[w-e-w]

if you want my opinion about the image fade in animation
I would say make the time shorter if not just don't have any animation at all
I'm sure some people would like it (I like it myself at first)
but it quickly gets old, becomes useless eye candy that waste time

like this is just my opinion

[gutris1]

if you want my opinion about the image fade in animation I would say make the time shorter if not just don't have any animation at all I'm sure some people would like it (I like it myself at first) but it quickly gets old, becomes useless eye candy that waste time

like this is just my opinion

haha,, thanks
it is indeed a copy from viyiviyi zoom image
I make it, so the zoom and dragging is not out of place
it keep centered, or fit to the edge of the screen when the image width is exceeding the lightbox
just like Photos app on windows

you're welcome to submit extensions for review but don't be like "here is a wall of text, what do you think?"

:D I'll add more words on the readme sometimes.

did you deliberately hide them I don't know?

yes I did, most button doesnt really work anymore, thats why I hide them

btw, thank you.

[w-e-w]

live preview toggle dose work