Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Gelbooru-Prompt-Randomizer.json #391

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

RED1cat
Copy link
Contributor

@RED1cat RED1cat commented Dec 13, 2024

Info

https://github.com/RED1cat/Gelbooru-Prompt-Randomizer

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 21, 2024

didn't found any particular issues with the extensions itself

but you entry has an extra comma at the end of the tags which makes the json invalid

I fixed it


this is just a pure suggestion, decide yourself if you think these are good ideas

currently your extension workflow is, click Randomize button and the current prompt will be replaced
while this works if you just want random and nothing else it doesn't play well with other aspects of the us such as lora
as every time you randomize the current prompt is replaced
not to mention I think it's quite possible that users have some extra prompts themselves that they may wish to add in
and after every Randomize the user has to scroll up and down the page in order to see the new random prompt, this gets tedious quite quickly

I would suggest that you add a custom text box output for the random generated prompts
and let the user decide if they actually wish to use the prompt in their current prompts

and adding couple of method of applying to current prompts as opposed to "just replace"
such as

  • append
  • prepend
  • and possibly even advanced ones such as keeping extra networks the same or something not too sure how useful this will be

at the end of the day if the random prompts are inside a different text box they can always copy and modify them themselves to suit their needs as opposed to having all everything done automatically

it is totally possible that there are people that find automatically applying and replacing current prompt is useful
in this case you can always keep it as an option

@w-e-w w-e-w merged commit 0c3da1f into AUTOMATIC1111:extensions Dec 21, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
@RED1cat
Copy link
Contributor Author

RED1cat commented Dec 24, 2024

This is my first experience writing an extension, so it turned out to be a bit primitive design. Thanks for the ideas for improving the extension, I'll try to use them in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants