Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vfx_workflow extension #389

Draft
wants to merge 2 commits into
base: extensions
Choose a base branch
from

Conversation

babydjac
Copy link

@babydjac babydjac commented Nov 24, 2024

Info

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 22, 2024

reviewed

@w-e-w w-e-w marked this pull request as draft December 22, 2024 16:23
@gutris1
Copy link
Contributor

gutris1 commented Dec 22, 2024

reviewed

breh thats cruel
btw, if I do PR now will it be merged
or still need to wait for AUTO to come back?

@w-e-w
Copy link
Collaborator

w-e-w commented Dec 22, 2024

breh thats cruel

are you saying this knowing what he has done?
you don't hard-code a path and expect user to change it just by leaving a in line comment
if you also don't for no reason unconditionally printing NSFW "art" to the consol
I have no issues with easter eggs, but this goes over the line

no I don't think this is cruel
I was halfway in closing this PR without giving any explanation

https://docs.github.com/en/site-policy/acceptable-use-policies/github-sexually-obscene-content

We do not allow sexually themed or suggestive content that serves little or no purpose other than to solicit an erotic or shocking response


btw, if I do PR now will it be merged
or still need to wait for AUTO to come back?

are you asking about the main repo?
master branch still only can be merge by AUTO
but PR's to dev branch now can be meagred by me and catboxanon

note I'm not very active recently as I'm extremely busy with other things at the moment

@gutris1
Copy link
Contributor

gutris1 commented Dec 23, 2024

are you asking about the main repo? master branch still only can be merge by AUTO but PR's to dev branch now can be meagred by me and catboxanon

nah, I'm asking about this extension repo
oh I see you did merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants